Hi, On Sun, Jul 8, 2012 at 12:36 PM, Måns Rullgård <[email protected]> wrote: > "Ronald S. Bultje" <[email protected]> writes: >> On Wed, Jul 4, 2012 at 2:09 PM, Måns Rullgård <[email protected]> wrote: >>> "Ronald S. Bultje" <[email protected]> writes: >>>> On Tue, Jul 3, 2012 at 8:14 PM, Ronald S. Bultje <[email protected]> >>>> wrote: >>>>> From: "Ronald S. Bultje" <[email protected]> >>>>> >>>>> This allows compiling and running these tests on systems lacking a built- >>>>> in version of getopt(), such as MSVC. >>>>> --- >>>>> configure | 2 ++ >>>>> libavcodec/dct-test.c | 7 +++++ >>>>> libavcodec/fft-test.c | 6 ++++ >>>>> libavcodec/getopt.c | 84 >>>>> +++++++++++++++++++++++++++++++++++++++++++++++++ >>>>> 4 files changed, 99 insertions(+) >>>>> create mode 100644 libavcodec/getopt.c >>>> >>>> Ping. >>> >>> No matter what, a replacement getopt.c does *not* belong in libavcodec/ >> >> So where does it go? Also, ping re: rest of the patch. > > It does not go anywhere in our libs for a very simple reason: it uses > global variables.
They're static, not global. Anyway, Anton already supplied a better patch-set so this trollwar can be abandoned. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
