On Sun, Jul 15, 2012 at 08:00:26PM +0300, Martin Storsjö wrote: > From: Mohammad Alsaleh <[email protected]> > > Passing a cutoff value < sample_rate/256 will cause a crash. > Also, values >20000 will have no effect and 20000 will be used anyway. > > Signed-off-by: Mohammad Alsaleh <[email protected]> > --- > Got this from a contributor on irc (who probably isn't subscribed), > ok'd by me, will push later unless there's objections. > > libavcodec/libfdk-aacenc.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/libavcodec/libfdk-aacenc.c b/libavcodec/libfdk-aacenc.c > index b2bfad2..f2c3fbd 100644 > --- a/libavcodec/libfdk-aacenc.c > +++ b/libavcodec/libfdk-aacenc.c > @@ -231,6 +231,11 @@ static av_cold int aac_encode_init(AVCodecContext *avctx) > } > > if (avctx->cutoff > 0) { > + if (avctx->cutoff < (avctx->sample_rate + 255) >> 8) { > + av_log(avctx, AV_LOG_ERROR, "cutoff valid range is %d-20000\n", > + (avctx->sample_rate + 255) >> 8); > + goto error; > + } > if ((err = aacEncoder_SetParam(s->handle, AACENC_BANDWIDTH, > avctx->cutoff)) != AACENC_OK) { > av_log(avctx, AV_LOG_ERROR, "Unable to set the encoder bandwith > to %d: %s\n", > --
LGTM _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
