[libav-devel] [PATCH 1/1] rtp: fix SDP generation with PCM_* codecs There was missing informations - inside SDP file - about media attributes i.e. a=rtpmap:11 L16/16000/1 Accordingly to https://tools.ietf.org/html/rfc3551#section-6 the static profiles are under PT 96

[Adriano Pallavicino]

---
 libavformat/sdp.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/libavformat/sdp.c b/libavformat/sdp.c
index 1867225..ec9ec41 100644
--- a/libavformat/sdp.c
+++ b/libavformat/sdp.c
@@ -457,19 +457,19 @@ static char *sdp_write_media_attributes(char *buff, int 
size, AVCodecContext *c,
             }
             break;
         case CODEC_ID_PCM_S16BE:
-            if (payload_type >= RTP_PT_PRIVATE)
+            if (payload_type <= RTP_PT_PRIVATE)
                 av_strlcatf(buff, size, "a=rtpmap:%d L16/%d/%d\r\n",
                                          payload_type,
                                          c->sample_rate, c->channels);
             break;
         case CODEC_ID_PCM_MULAW:
-            if (payload_type >= RTP_PT_PRIVATE)
+            if (payload_type <= RTP_PT_PRIVATE)
                 av_strlcatf(buff, size, "a=rtpmap:%d PCMU/%d/%d\r\n",
                                          payload_type,
                                          c->sample_rate, c->channels);
             break;
         case CODEC_ID_PCM_ALAW:
-            if (payload_type >= RTP_PT_PRIVATE)
+            if (payload_type <= RTP_PT_PRIVATE)
                 av_strlcatf(buff, size, "a=rtpmap:%d PCMA/%d/%d\r\n",
                                          payload_type,
                                          c->sample_rate, c->channels);
@@ -542,7 +542,7 @@ static char *sdp_write_media_attributes(char *buff, int 
size, AVCodecContext *c,
                                          8000, c->channels);
             break;
         case CODEC_ID_ADPCM_G726: {
-            if (payload_type >= RTP_PT_PRIVATE)
+            if (payload_type <= RTP_PT_PRIVATE)
                 av_strlcatf(buff, size, "a=rtpmap:%d G726-%d/%d\r\n",
                                          payload_type,
                                          c->bits_per_coded_sample*8,
-- 
1.7.10.4

_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel