On 07/24/2012 07:56 PM, Jordi Ortiz wrote:
> Without this patch a user a bit absent-minded may not notice that the
> connection
> doesn't work because port is missing.
> ---
> libavformat/sctp.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/libavformat/sctp.c b/libavformat/sctp.c
> index 7bcb5ae..b8ab63e 100644
> --- a/libavformat/sctp.c
> +++ b/libavformat/sctp.c
> @@ -170,8 +170,12 @@ static int sctp_open(URLContext *h, const char *uri, int
> flags)
>
> av_url_split(proto, sizeof(proto), NULL, 0, hostname, sizeof(hostname),
> &port, path, sizeof(path), uri);
> - if (strcmp(proto,"sctp") || port <= 0 || port >= 65536)
> + if (strcmp(proto, "sctp"))
> return AVERROR(EINVAL);
> + if (port <= 0 || port >= 65536) {
> + av_log(s, AV_LOG_ERROR, "Port missing in uri\n");
> + return AVERROR(EINVAL);
> + }
>
> s->max_streams = 0;
> p = strchr(uri, '?');
Looks nice =)
--
Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
