On Wed, 25 Jul 2012, Antti Seppälä wrote:

It should be possible to specify usernames in http requests containing
urlencoded characters. This patch adds support for decoding the auth
strings.

Signed-off-by: Antti Seppälä <[email protected]>
---
libavformat/Makefile    |   11 +++---
libavformat/httpauth.c  |   23 +++++++++---
libavformat/urldecode.c |   86 +++++++++++++++++++++++++++++++++++++++++++++++
libavformat/urldecode.h |   35 +++++++++++++++++++
4 files changed, 144 insertions(+), 11 deletions(-)
create mode 100644 libavformat/urldecode.c
create mode 100644 libavformat/urldecode.h

Except for Diego's style nitpicks, this looks good to me.

My initial thought was that this should be handled by av_url_split/ff_url_join, but then we'd have to split the auth fields into user/pass within those functions already, which would require lots of changes all over the place. So I'm ok with this approach.

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to