On Wed, Jul 25, 2012 at 8:42 PM, Ronald S. Bultje <[email protected]> wrote:
>
> From: "Ronald S. Bultje" <[email protected]>
>
> This fixes "make fate-eval" on MSVC builds. Without this, the test outputs
> "-1.#NaN" instead of "nan" on MSVS 2010.
> ---
>  libavutil/eval.c |    5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/libavutil/eval.c b/libavutil/eval.c
> index ef37ad8..6131263 100644
> --- a/libavutil/eval.c
> +++ b/libavutil/eval.c
> @@ -671,6 +671,11 @@ int main(int argc, char **argv)
>          av_expr_parse_and_eval(&d, *expr,
>                                 const_names, const_values,
>                                 NULL, NULL, NULL, NULL, NULL, 0, NULL);
> +#ifdef _MSC_VER
> +        if (isnan(d))
> +            printf("'%s' -> nan\n\n", *expr);
> +        else
> +#endif
>          printf("'%s' -> %f\n\n", *expr, d);
>      }
>

Funny, when I proposed this without the MSC ifdef, you were wholly against it.

And once again I will state that a conformant libc has the freedom to
print "[-]nan(n-char-sequence)". So why not just drop the ifdef?
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to