On 07/26/2012 03:38 PM, Ronald S. Bultje wrote:
> I'm not sure why, we do similar hacks for pretty much all math
> functions and a few other string-related functions in lavu already.

You refer to libm.h

> Why is snprintf() different?

- it is not always_inline, so we could have clashes (fixed with the
namespace+macro thing)

- originally it was put in a public header

beside that the rest is fine.

To restate, if we want it always inline just having it on a private
header would be ok, if we want to use it normally we just need to
namespace it and use a private header.

Where it should live is not a huge concern, since we have other
replacement functions pending we could put all of them in a os_support.c
in libavutil and use a single private header for all of them.

Sounds fine?

lu

-- 

Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to