On Fri, Jul 27, 2012 at 11:42:04AM -0700, Ronald S. Bultje wrote:
> On Fri, Jul 27, 2012 at 11:39 AM, Diego Biurrun <[email protected]> wrote:
> > On Thu, Jul 26, 2012 at 08:38:27PM -0700, Ronald S. Bultje wrote:
> >> --- a/libavcodec/x86/proresdsp.asm
> >> +++ b/libavcodec/x86/proresdsp.asm
> >> @@ -406,27 +405,25 @@ cglobal prores_idct_put_10_%1, 4, 4, %2
> >>
> >> -INIT_XMM
> >> -%define SIGNEXTEND signextend_sse2
> >> -idct_put_fn sse2, 16
> >> -INIT_XMM
> >> -%define SIGNEXTEND signextend_sse4
> >> -idct_put_fn sse4, 16
> >> -INIT_AVX
> >> -idct_put_fn avx,  16
> >> +INIT_XMM sse2
> >> +idct_put_fn 16
> >> +INIT_XMM sse4
> >> +idct_put_fn 16
> >> +INIT_XMM avx
> >> +idct_put_fn 16
> >
> > What's with
> >
> >   INIT_XMM avx
> >
> > vs.
> >
> >   INIT_AVX
> >
> > ?
> >
> > Patch does LGTM otherwise.
> 
> See x86inc.asm, INIT_AVX is the deprecated method, INIT_XMM avx is the
> correct method.

Push anytime.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to