"Ronald S. Bultje" <[email protected]> writes: > Hi, > > On Sat, Jul 28, 2012 at 11:24 AM, Ronald S. Bultje <[email protected]> wrote: >> On Sat, Jul 28, 2012 at 10:52 AM, Luca Barbato <[email protected]> wrote: >>> On 07/28/2012 05:05 PM, Ronald S. Bultje wrote: >>>> On Fri, Jul 27, 2012 at 5:48 PM, Ronald S. Bultje <[email protected]> >>>> wrote: >>>>> On Fri, Jul 27, 2012 at 2:43 PM, Måns Rullgård <[email protected]> wrote: >>>>>> However, the question still remains why it is in generic code. >>>>> >>>>> That's hard to say in hindsight, but it seems it was for simplicity so >>>>> that you don't have to add it to each individual mmx function, thus >>>>> making the asumption they would all use movntq. See also (directly >>>>> under the #endif, just outside the context in this patch) its use of >>>>> EMMS, even if it only called SSE2 functions and thus the MMX state was >>>>> never clobbered... >>>> >>>> Ping on the patch itself also - can we keep it, at least for now? I >>>> don't midn refactoring sfence out at some point, but that's a separate >>>> task from the point of this patch. >>> >>> Probably we should keep notes or bite the bullet and replace this happy >>> monster. >>> >>> I wouldn't spend more time discussing this specific patch for now. >> >> So can I push it? > > Ping?
Very well, it will only make it marginally uglier than it already is. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
