On Mon, Jul 30, 2012 at 10:07 AM, Ronald S. Bultje <[email protected]> wrote:
> Hi,
>
> On Wed, Jul 25, 2012 at 10:40 PM, Luca Barbato <[email protected]> wrote:
>> On 07/26/2012 05:37 AM, Ronald S. Bultje wrote:
>>> From: "Ronald S. Bultje" <[email protected]>
>>>
>>> ---
>>>  libavutil/eval.c |   35 +++++++++++++++++++++++++++++++++++
>>>  1 file changed, 35 insertions(+)
>>>
>>
>> As for the snprintf, I'd rather have those workaround in os_support,
>> move it to libavutil and have os_support.h included.
>>
>> I'd move this code to
>>
>> ff_strtod()
>>
>> and have #define strtod ff_strtod
>
> I'm a little bit concerned about having a function called ff_strtod()
> which is only called from a function called av_strtod().
>

What about avpriv_strtod_internal()

The longer name makes it less likely someone will use it accidentally
and the avpriv_ prefix should allow it to be used in all of the
libraries.
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to