On Tue, Jul 31, 2012 at 11:53:24AM -0400, Justin Ruggles wrote:
> On 07/31/2012 10:37 AM, Diego Biurrun wrote:
> > On Mon, Jul 30, 2012 at 01:48:09PM -0400, Justin Ruggles wrote:
> >>
> [...]
> >> +%if mmsize == 8
> >>      punpckldq  %1, %1
> >> +%elif mmsize == 16
> >> +    %if %0 > 1 && cpuflag(avx)
> >> +    vbroadcastss %1, %2
> >> +    %elif cpuflag(sse2)
> >>      pshufd  %1, %1, 0
> >> +    %else ; sse
> >> +    shufps  %1, %1, 0
> >> +    %endif
> >> +%elif mmsize == 32
> >> +    %if %0 > 1
> >> +    vbroadcastss %1, %2
> >> +    %else
> >> +    vperm2f128 %1, %1, %1, 0
> >> +    shufps     %1, %1, 0
> >> +    %endif
> >> +%endif
> >>  %endmacro
> > 
> > ifdefs are not indented anywhere else, so I'd suggest maintaining
> > the current style.
> 
> Have you looked at x86inc.asm?

Yes, but apparently not enough of it is sticking in memory thus far.
Scratch my comments for this patch.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to