On Tue, Jul 31, 2012 at 03:46:55PM -0700, Ronald S. Bultje wrote: > On Tue, Jul 31, 2012 at 3:43 PM, Diego Biurrun <[email protected]> wrote: > > On Wed, Jul 25, 2012 at 08:30:19PM -0700, Ronald S. Bultje wrote: > >> > >> --- a/libavcodec/dct-test.c > >> +++ b/libavcodec/dct-test.c > >> @@ -85,7 +85,7 @@ static const struct algo fdct_tab[] = { > >> { "IJG-AAN-INT", ff_fdct_ifast, SCALE_PERM }, > >> { "IJG-LLM-INT", ff_jpeg_fdct_islow_8, NO_PERM }, > >> > >> -#if HAVE_MMX > >> +#if HAVE_MMX && HAVE_INLINE_ASM > >> { "MMX", ff_fdct_mmx, NO_PERM, AV_CPU_FLAG_MMX > >> }, > >> { "MMX2", ff_fdct_mmx2, NO_PERM, > >> AV_CPU_FLAG_MMX2 }, > >> { "SSE2", ff_fdct_sse2, NO_PERM, > >> AV_CPU_FLAG_SSE2 }, > > > > Drop this controversial hunk from the patch for now, the rest is OK. > > Can we please leave structure of asm init functions out of this > discussion? I'm leaving it exactly as it was before, so if you want to > change that, it should be discussed separately and done on its own > merit, not within this discussion.
Sure, leave the init part as-is, drop the hunk above and we're good to go. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
