Hi, On Wed, Aug 1, 2012 at 5:38 PM, Loren Merritt <[email protected]> wrote: > On Thu, 2 Aug 2012, Diego Biurrun wrote: >> On Wed, Aug 01, 2012 at 07:41:01AM -0700, Ronald S. Bultje wrote: >>> On Wed, Aug 1, 2012 at 5:30 AM, Diego Biurrun <[email protected]> wrote: >>>> --- a/libavcodec/x86/fft_mmx.asm >>>> +++ b/libavcodec/x86/fft_mmx.asm >>>> @@ -105,7 +105,8 @@ SECTION_TEXT >>>> pxor %3, [ps_m1p1] ; {t8,t7} >>>> mova %6, %1 >>>> - pswapd %3, %3 >>>> + movd [r0+12], %3 >>>> + punpckhdq %3, [r0+8] >>> >>> Needs rebase? >> >> No, it's the only caller with two identical arguments, so I moved the >> macro branch for identical arguments out of the macro and into the caller. > > But then it doesn't generate pswapd in the 3dnow2 instantiation. > > Or you could make it not have two identical arguments; there's a spare > mmreg (%4) at that point.
Earlier, I recommended using a separate macro for in-place PSWAPD, can you do that Diego? Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
