On 07/31/2012 06:17 PM, Diego Biurrun wrote: > --- > libavcodec/x86/ac3dsp.asm | 82 ++++++++++++++++++++++---------------------- > 1 files changed, 41 insertions(+), 41 deletions(-) > > diff --git a/libavcodec/x86/ac3dsp.asm b/libavcodec/x86/ac3dsp.asm > index e000565..841de90 100644 > --- a/libavcodec/x86/ac3dsp.asm > +++ b/libavcodec/x86/ac3dsp.asm > @@ -41,8 +41,8 @@ SECTION .text > ; void ff_ac3_exponent_min(uint8_t *exp, int num_reuse_blocks, int nb_coefs) > > ;----------------------------------------------------------------------------- > > -%macro AC3_EXPONENT_MIN 1 > -cglobal ac3_exponent_min_%1, 3,4,2, exp, reuse_blks, expn, offset > +%macro AC3_EXPONENT_MIN 0 > +cglobal ac3_exponent_min, 3, 4, 2, exp, reuse_blks, expn, offset
Can you leave the 3 numerical arguments together like it is currently, here and elsewhere in this file? I happen to like it better that way, and we don't have strict style guidelines for yasm code. [...] > movdqa m0, [mant_cntq ] > movdqa m1, [mant_cntq+ 1*16] > paddw m0, [mant_cntq+ 2*16] > @@ -373,20 +374,20 @@ cglobal ac3_compute_mantissa_size_sse2, 1,2,4, > mant_cnt, sum > ; void ff_ac3_extract_exponents(uint8_t *exp, int32_t *coef, int nb_coefs) > > ;------------------------------------------------------------------------------ > > -%macro PABSD_MMX 2 ; src/dst, tmp > +%macro PABSD 1-2 ; src/dst, unused Please put the arguments pertaining to the macro in general, not just the ssse3 version. e.g. src/dst, tmp (unused for ssse3) > +%if cpuflag(ssse3) > + pabsd %1, %1 > +%else ; src/dst, tmp instead of putting it down here The rest of the patch looks fine. -Justin _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
