On Sat, Aug 04, 2012 at 01:13:07AM -0400, Justin Ruggles wrote: > --- a/libavcodec/x86/dsputil_yasm.asm > +++ b/libavcodec/x86/dsputil_yasm.asm > @@ -1054,50 +1054,50 @@ emu_edge mmx > > -; %4 = CLIPD function takes min/max as float instead of int (CLIPD_SSE2) > -%macro VECTOR_CLIP_INT32 4-5 > -cglobal vector_clip_int32%5, 5,5,%1, dst, src, min, max, len > -%if %4 > + > +%macro VECTOR_CLIP_INT32 2 > +cglobal vector_clip_int32, 5,5,11, dst, src, min, max, len > +%if notcpuflag(sse4) && cpuflag(sse2) && notcpuflag(atom)
Is the description of %4 worth maintaining as a comment? It's not immediately obvious why there is a special case for SSE2. > - cvtsi2ss m4, minm > - cvtsi2ss m5, maxm > + cvtsi2ss m4, minm > + cvtsi2ss m5, maxm stray whitespace change > --- a/libswscale/x86/scale.asm > +++ b/libswscale/x86/scale.asm > @@ -62,13 +62,11 @@ cglobal hscale%1to%2_%4, %5, 10, %6, pos0, dst, w, > srcmem, filter, fltpos, fltsi > %if %2 == 19 > -%if mmsize == 8 ; mmx > - mova m2, [max_19bit_int] > -%elif cpuflag(sse4) > +%if cpuflag(sse4) || mmsize == 8 > mova m2, [max_19bit_int] > -%else ; ssse3/sse2 Why do you drop the ssse3 from the comment? I consider this whole hunk unrelated; move it to a separate patch. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
