On Sat, Aug 04, 2012 at 11:49:15AM +0200, Anton Khirnov wrote:
> ---
>  Makefile     |    2 +
>  avconv.c     | 2227 
> ++--------------------------------------------------------
>  avconv.h     |  360 ++++++++++
>  avconv_opt.c | 1916 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 2326 insertions(+), 2179 deletions(-)
>  create mode 100644 avconv.h
>  create mode 100644 avconv_opt.c

avconv: split option parsing into a separate file

> --- /dev/null
> +++ b/avconv.h
> @@ -0,0 +1,360 @@
> +
> +#endif // AVCONV_H

Use /* */ like everywhere else please.

> --- /dev/null
> +++ b/avconv_opt.c
> @@ -0,0 +1,1916 @@
> +/*
> + * avconv options parsing

option

> + * Copyright (c) 2000-2012 The libav developers.

I don't think this denotes a proper legal entity, so just drop it.

I'll do a more thorough review once I can apply this cleanly to
some tree of mine.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to