On Tue, Aug 07, 2012 at 02:11:36AM +0100, Mans Rullgard wrote:
> Many compilers need special flags to compile *.h files as regular
> source code, if they will do so at all.  Rather than hoping all
> compilers will have such a flag and adding mappings for it, create
> wrapper .c files for test building single headers.
> 
> ---
>  Makefile    | 4 ++--
>  common.mak  | 8 +++++---
>  library.mak | 2 +-
>  3 files changed, 8 insertions(+), 6 deletions(-)

This is missing an update of the .gitignore patterns.

> --- a/Makefile
> +++ b/Makefile
> @@ -45,8 +45,8 @@ COMPILE_S = $(call COMPILE,AS)
>  
> -%.ho: %.h
> -     $(CC) $(CCFLAGS) -c $(CC_O) -x c $<
> +%.h.c:
> +     $(Q)echo '#include "$*.h"' >$@
>  
>  %.ver: %.v
>       $(Q)sed 's/$$MAJOR/$($(basename $(@F))_VERSION_MAJOR)/' $^ > $@

Please add a space after the redirection operator.  Make has so many
special character combinations that I find it hard to read when they
are mixed with shell syntax.

Patch does LGTM.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to