On Sat, Aug 11, 2012 at 01:29:19PM -0700, Ronald S. Bultje wrote: > On Sat, Aug 11, 2012 at 11:12 AM, Diego Biurrun <[email protected]> wrote: > > > > Now with only minimal changes to x86inc.asm. > > No. Sorry, the patch won't go in. I'm against it. Let's move on.
Does that mean that you redo and rebase my patchset? I take patches ... I have a lot of work queued up behind this and my motivation to redo and rebase this patchset yet again are low. I have already let your cpuflags and yasmification patches go in first and done the necessary adjustments on my branch. This was considerable work due to the number of conflicts and the retesting on multiple platforms that was incurred. You complain that you are the one to sync x86inc.asm with x264 and that fixing conflicts will be your task. I have done upstream syncing within MPlayer and FFmpeg for many years and with many libraries: libmpeg2, libdvdread, libdvdnav, libdvdcss, liba52, tremor, mpg123, vidix, FFmpeg, the Debian packaging infrastructure, even before the days of advanced tools like Git. So sorry, you cannot just pull rank on me and tell me I don't know how much work it is. The probabilities of conflicts are low and will be trivial to fix. If you want me to, I can move the %define to the top of the file where the %define for program_name is already different from x264. Then any conflicts that arise would have arisen in that spot anyway (and will be equally trivial to fix). Daniel says that this patchset will make his life harder. No offense, but I have 30+ patches, not one, queued up behind this. Also, half of mine are already OKed and not still under review, so the ETA is in the very near future. Loren does not want mmxext for x264, this is a pity. But a majority of devs prefer mmxext for libav and the name makes more sense than mmx2, witness that mmxext is actually used outside of libav/x264/ffmpeg/mplayer. You still don't like it? Many throats around here are still aching from swallowing MSVC-shaped toads. I'd say it's your turn to compromise now. I remember you saying that whoever does the work should get to make the decisions. In this case, that would be me. So let's please get this patch in and move on. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
