On Mon, Aug 13, 2012 at 11:52:27PM +0100, Mans Rullgard wrote: > It is impossible for bits to be 15 here so the special case is > not needed. > > Signed-off-by: Mans Rullgard <[email protected]> > --- > libavcodec/g723_1.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/g723_1.c b/libavcodec/g723_1.c > index fd03ed9..793b2d3 100644 > --- a/libavcodec/g723_1.c > +++ b/libavcodec/g723_1.c > @@ -283,12 +283,8 @@ static int scale_vector(int16_t *dst, const int16_t > *vector, int length) > max = FFMIN(max, 0x7FFF); > bits = normalize_bits(max, 15); > > - if (bits == 15) > - for (i = 0; i < length; i++) > - dst[i] = vector[i] * 0x7fff >> 3; > - else > - for (i = 0; i < length; i++) > - dst[i] = vector[i] << bits >> 3; > + for (i = 0; i < length; i++) > + dst[i] = vector[i] << bits >> 3; > > return bits - 3; > } > --
LGTM too _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
