Diego Biurrun <[email protected]> writes: > On Wed, Aug 15, 2012 at 10:21:00AM +0200, Janne Grunau wrote: >> On 2012-08-14 23:21:26 +0200, Diego Biurrun wrote: >> > --- >> > libavcodec/w32pthreads.h | 3 +++ >> > 1 files changed, 3 insertions(+), 0 deletions(-) >> > >> > diff --git a/libavcodec/w32pthreads.h b/libavcodec/w32pthreads.h >> > index ae6ceb9..8489f71 100644 >> > --- a/libavcodec/w32pthreads.h >> > +++ b/libavcodec/w32pthreads.h >> > @@ -39,6 +39,9 @@ >> > #include <windows.h> >> > #include <process.h> >> > >> > +#include "libavutil/internal.h" >> > +#include "libavutil/mem.h" >> > + >> > typedef struct { >> > void *handle; >> > void *(*func)(void* arg); >> >> Not opposing to the patch but w32pthreads.h is no ordinary header and >> should be only included in pthreads.c. So it's rather pointless that it >> passes checkheaders. > > It is included in > > libavcodec/pthread.c > libavcodec/vp8.h > libavformat/network.c > > not only in pthreads.c...
That is a huge bug. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
