On Fri, 17 Aug 2012 17:59:08 +0200, Diego Biurrun <[email protected]> wrote: > On Wed, Aug 15, 2012 at 10:37:18AM +0200, Anton Khirnov wrote: > > show_foo() functions are declared as void show_foo(void), but called as > > int show_foo(const char*, const char*). > > --- > > avconv_opt.c | 3 ++- > > avplay.c | 6 ++++-- > > avprobe.c | 3 ++- > > cmdutils.c | 27 +++++++++++++++++++-------- > > cmdutils.h | 16 ++++++++-------- > > cmdutils_common_opts.h | 32 ++++++++++++++++---------------- > > 6 files changed, 51 insertions(+), 36 deletions(-) > > Adding unused parameters just to match the function pointer signature > feels wrong. Why don't you add another function pointer with matching > signature to the union in cmdutils.h? >
What exactly feels wrong about it? It looks very right to me. Your suggestion is more code with no benefit. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
