On Sun, Aug 19, 2012 at 08:09:38AM +0200, Anton Khirnov wrote: > > On Sat, 18 Aug 2012 22:32:15 -0700, "Ronald S. Bultje" <[email protected]> > wrote: > > From: "Ronald S. Bultje" <[email protected]> > > > > --- > > libavcodec/aacdec.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c > > index 1c59ec5..bf99cc3 100644 > > --- a/libavcodec/aacdec.c > > +++ b/libavcodec/aacdec.c > > @@ -1257,9 +1257,10 @@ static inline float *VMUL4S(float *dst, const float > > *v, unsigned idx, > > unsigned sign, const float *scale) > > { > > unsigned nz = idx >> 12; > > - union av_intfloat32 s = { .f = *scale }; > > + union av_intfloat32 s; > > union av_intfloat32 t; > > > > + s.f = *scale; > > t.i = s.i ^ (sign & 1U<<31); > > *dst++ = v[idx & 3] * t.f; > > > > Please, stop those euphemisms. I'm sure the actual reason for this patch is > not > simplifying the code, but making it parsable by msvc. In that case, just say > so. > Obscuring the purpose is not helping anyone. > > Also, I wonder why is this needed. Your converter can do this replacement for > structs, can't it trivially do the same for unions?
+1 in any case it's hardly simplification _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
