On Sat, Aug 18, 2012 at 05:30:35PM +0200, Guillaume Martres wrote:
> From: Guillaume Martres <[email protected]>
>
> ---
> libavcodec/cabac.c | 16 ++++++++--------
> libavcodec/cabac.h | 4 ++++
> 2 files changed, 12 insertions(+), 8 deletions(-)
The log message is wrong; you seem to have missed amending it
after changing what the patch does.
Patch itself is OK, minor nits below.
> --- a/libavcodec/cabac.c
> +++ b/libavcodec/cabac.c
> @@ -54,7 +54,7 @@ uint8_t ff_h264_cabac_tables[512 + 4*2*64 + 4*64 + 63] = {
>
> -static const uint8_t lps_range[64][4]= {
> +const uint8_t ff_lps_range[64][4]= {
Extra good karma for adding a space before = while you're changing
the line anyway, more below.
> --- a/libavcodec/cabac.h
> +++ b/libavcodec/cabac.h
> @@ -39,6 +39,10 @@
> #define CABAC_BITS 16
> #define CABAC_MASK ((1<<CABAC_BITS)-1)
>
> +extern const uint8_t ff_lps_range[64][4];
> +extern const uint8_t ff_mps_state[64];
> +extern const uint8_t ff_lps_state[64];
nit: switching line 2 and 3 would make more sense IMO
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
