On Mon, Aug 20, 2012 at 11:14:08AM -0400, Justin Ruggles wrote: > On 08/09/2012 09:50 AM, Diego Biurrun wrote: > > -INIT_XMM > > -FLOAT_TO_INT16 sse2, 2 > > -INIT_MMX > > -FLOAT_TO_INT16 sse, 0 > > +INIT_XMM sse2 > > +FLOAT_TO_INT16 2 > > +INIT_MMX sse > > +FLOAT_TO_INT16 0 > > %define cvtps2pi pf2id > > -FLOAT_TO_INT16 3dnow, 0 > > +INIT_MMX 3dnow > > +FLOAT_TO_INT16 0 > > %undef cvtps2pi > > Patch looks ok.
Thanks for the review. > Would you also be willing to send a follow-up patch to use capitalized > CVTPS2PI and define it to either cvtps2pi or pf2id? This would be more > consistent with how we do other instruction emulation and make it > clearer in the code that it isn't necessarily using the cvtps2pi > instruction. I would be willing to do that, but I'm unwilling to sink more time into a patchset the preliminaries of which have been rejected. Good luck getting Ronald to redo my branch his way, sorry ... Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
