On Sat, 8 Sep 2012, Måns Rullgård wrote:
Martin Storsjö <[email protected]> writes:
On Sat, 8 Sep 2012, Måns Rullgård wrote:
Hendrik Leppkes <[email protected]> writes:
On Sat, Sep 8, 2012 at 12:09 PM, Ronald S. Bultje <[email protected]>wrote:
This sounds like the wrong fix tbh. The first chunk looks OK but
wouldn't other systems, eg old GCC versions, be similarly affected?
Shouldn't the true fix live elsewhere, ie fix the log2() check?
The log2 check is fine in theory. The linker somewhere finds a log2
function to link in, but without a function declaration in the header.
Find out where that log2 is coming from and what it really is.
It seems that the log2 is present in the static libc that MSVC
normally uses (but not in the dynamically loaded one),
Sorry, this was a bit badly worded - in the static libc yes, but not in
the dynamic libc, if one were to choose to use that one instead.
Can you explain that in terms that make sense? Is it available to us or
not?
Yes, it seems to be available (in some configurations), but Hendrik seems
to run into some fate test issues when using it - I'll try to look into it
(my build env for this isn't complete yet).
and the headers don't contain any declaration of it.
If the function exists we can add a declaration easily enough.
Hmm, ok. I'll look into it further and see what the fate failures are that
he mentions, related to this function.
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
