On Tue, Sep 25, 2012 at 10:13:16AM -0400, Justin Ruggles wrote:
> ---
>    C: 34080
> SSE4:  1274

impressive...

> --- /dev/null
> +++ b/libavfilter/af_volume.h
> @@ -0,0 +1,52 @@
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with Libav; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 
> USA
> + */
> +
> +/**
> + * @file
> + * audio volume filter
> + */
> +
> +#include "libavutil/common.h"
> +#include "libavutil/float_dsp.h"
> +#include "libavutil/opt.h"

multiple inclusion guards

> --- a/libavfilter/x86/Makefile
> +++ b/libavfilter/x86/Makefile
> @@ -1,3 +1,5 @@
>  MMX-OBJS-$(CONFIG_YADIF_FILTER)              += x86/yadif.o
>  MMX-OBJS-$(CONFIG_GRADFUN_FILTER)            += x86/gradfun.o
>  YASM-OBJS-$(CONFIG_HQDN3D_FILTER)            += x86/hqdn3d.o
> +OBJS-$(CONFIG_VOLUME_FILTER)                 += x86/af_volume_init.o
> +YASM-OBJS-$(CONFIG_VOLUME_FILTER)            += x86/af_volume.o

Move the OBJS line to the top of the file.

> --- /dev/null
> +++ b/libavfilter/x86/af_volume_init.c
> @@ -0,0 +1,38 @@
> +    if (sample_fmt == AV_SAMPLE_FMT_S16) {
> +        if (EXTERNAL_SSE4(mm_flags) && vol->volume_i < 65536) {
> +            vol->scale_samples_int = ff_scale_samples_s16_sse4;
> +            vol->samples_align = 8;

nit: align

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to