On 09/26/2012 09:59 AM, Diego Biurrun wrote:
> On Tue, Sep 25, 2012 at 12:35:27PM -0400, Justin Ruggles wrote:
>> --- a/libavfilter/x86/af_volume_init.c
>> +++ b/libavfilter/x86/af_volume_init.c
>> @@ -34,5 +39,14 @@ void ff_volume_init_x86(VolumeContext *vol)
>> vol->scale_samples_int = ff_scale_samples_s16_sse4;
>> vol->samples_align = 8;
>> }
>> + } else if (sample_fmt == AV_SAMPLE_FMT_S32) {
>> + if (EXTERNAL_SSSE3(mm_flags)) {
>> + vol->scale_samples_int = ff_scale_samples_s32_ssse3;
>> + vol->samples_align = 4;
>> + }
>> + if (EXTERNAL_AVX(mm_flags)) {
>> + vol->scale_samples_int = ff_scale_samples_s32_avx;
>> + vol->samples_align = 4;
>
> nit: align
>
> Maybe factorize setting samples_align outside of the two if-blocks?
That wouldn't be correct. samples_align has been previously set to 1 for
the C version.
-Justin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
