On 09/27/2012 04:19 AM, Nathan Caldwell wrote: > From: Nicolas George <[email protected]> > > --- > Changelog | 1 + > configure | 5 ++ > doc/general.texi | 2 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/libopusdec.c | 206 > +++++++++++++++++++++++++++++++++++++++++++++++ > 6 files changed, 216 insertions(+) > create mode 100644 libavcodec/libopusdec.c [...] > + if (avc->extradata_size >= OPUS_HEAD_SIZE) { > + avc->delay = AV_RL16(avc->extradata + 10); [...] > + /* When seeking, it is recommended to start decoding 3840 samples (80ms) > prior to > + * the indended seek position to ensure the decoder has time to converge > before the seek point. > + */ > + avc->delay = 3840;
If 3840 is the decoder delay, we should use that for avc->delay at init instead of using pre-skip from the extradata, which is actually encoder delay. Also the field needs to be documented in avcodec.h for decoding. The rest of the patch LGTM. -Justin _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
