On Thu, Sep 27, 2012 at 12:57 PM, Luca Barbato <[email protected]> wrote:
> On 09/27/2012 08:20 PM, Dale Curtis wrote: > > The Chrome side patch set is here if you're curious: > > http://codereview.chromium.org/10912080/ > > + av_dict_set(&format_context->metadata, "skip_id3v1_tags", "", 0); > Looks like you might like a nicer way to turn off that. ^^ > Yes please! That was the best I could come up with on short notice. :) > > Regarding closing the codec context looks like there is something worthy > some more attention and discussion: > > avformat_free_context() does not call avcodec_close even if > find stream info does call avcodec_open2. > Yes, I've submitted patches to address a leaks here in the past if avformat_find_stream_info() fails. The last I looked at this, you couldn't always call avcodec_close() or you'd end up with a double-free, which is the reason for the checks we do before calling close: 165 // The conditions for calling avcodec_close(): 166 // 1. AVStream is alive. 167 // 2. AVCodecContext in AVStream is alive. 168 // 3. AVCodec in AVCodecContext is alive. - dale
_______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
