On 09/28/2012 05:14 AM, Diego Biurrun wrote:
> On Fri, Sep 28, 2012 at 12:54:11AM -0400, Justin Ruggles wrote:
>> --- a/libavfilter/af_volume.c
>> +++ b/libavfilter/af_volume.c
>> @@ -281,6 +259,10 @@ static void volume_init(VolumeContext *vol, enum
>> AVSampleFormat sample_fmt)
>> +
>> +#if ARCH_X86
>> + ff_volume_init_x86(vol);
>> +#endif
>
> Everywhere else we just do
>
> if (ARCH_X86)
>
> why not here as well?
>
>> --- a/libavfilter/x86/Makefile
>> +++ b/libavfilter/x86/Makefile
>> @@ -1,3 +1,5 @@
>> +OBJS-$(CONFIG_VOLUME_FILTER) += x86/af_volume_init.o
>> MMX-OBJS-$(CONFIG_YADIF_FILTER) += x86/yadif.o
>> MMX-OBJS-$(CONFIG_GRADFUN_FILTER) += x86/gradfun.o
>
> Please add an empty line to separate OBJS from MMX-OBJS.
>
>> --- /dev/null
>> +++ b/libavfilter/x86/af_volume_init.c
>> @@ -0,0 +1,38 @@
>> +
>> +#include "config.h"
>> +#include "libavutil/samplefmt.h"
>> +#include "libavutil/x86/cpu.h"
>> +#include "libavfilter/af_volume.h"
>> +
>> +void ff_volume_init_x86(VolumeContext *vol)
>> +{
>> + int mm_flags = av_get_cpu_flags();
>
> nit: You need libavutil/cpu.h for av_get_cpu_flags().
Fixed locally.
-Justin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
