Derek Buitenhuis <[email protected]> writes: > On 04/10/2012 12:43 PM, Mans Rullgard wrote: >> Instead of using an evil VLA, fall back to C version when edge >> emulation is needed. MPEG4 GMC is a rarely used fringe feature >> so the speed loss is an acceptable cost for cleaner code. > > While, IIRC, 'Scene' rules ban GMC usage, I've seen plenty of use in > the wild ;). (Checking more boxes in XviD's VFW config surely means > better quality!)
I take your word for it, even though I've rarely come across such files. >> -#if ARCH_X86_32 || !HAVE_YASM >> c->gmc = gmc_mmx; >> -#endif > > I'm sorta confused with these parts... I'm sure I'm just lacking context. The gmc function itself is only mmx. The old code has multiple wrappers using mmx or sse versions of the edge emulation function. Since the patch changes it to fall back to C code when edge emulation is needed, these wrappers are gone, leaving only a single (mmx) version of the gmc function. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
