On Sat, Oct 06, 2012 at 02:44:41AM +0300, Martin Storsjö wrote: > On Sat, 6 Oct 2012, Diego Biurrun wrote: > >On Sat, Oct 06, 2012 at 02:05:21AM +0300, Martin Storsjö wrote: > >>--- /dev/null > >>+++ b/libavformat/url-test.c > >>@@ -0,0 +1,55 @@ > >>+/* > >>+ * Copyright (c) 2012 Martin Storsjo > > > >No 'ö'? > > I prefer keeping the source files plain ascii as long as my name is > the only thing that would require utf8.
Aren't we modern enough to have UTF-8 in sources nowadays? > >>--- /dev/null > >>+++ b/tests/ref/fate/url > >>@@ -0,0 +1,10 @@ > >>+baz > >>+/foo/baz > >>+/baz > >>+/baz > >>+http://server/foo/baz > >>+http://server/foo/baz > >>+http://server/baz > >>+http://server/baz > >>+http://server/baz > >>+https://other/url > > > >I'd suggest that you move this patch to the end of the series so that > >you don't have to make small changes to the test program in every > >revision. But do whatever you prefer. > > Maybe, but adding them incrementally is slightly clearer about which > feature addition is tested by which commit. But I'm ok with it > either way if others prefer it one way or another as well. By all means keep it if you prefer. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
