On 2012-10-07 19:22:30 +0200, Diego Biurrun wrote:
> On Sun, Oct 07, 2012 at 06:50:44PM +0200, Janne Grunau wrote:
> > 
> > --- /dev/null
> > +++ b/libavcodec/x86/vc1dsp.h
> > @@ -0,0 +1,35 @@
> > +
> > +#ifndef AVCODEC_X86_VC1DSP_H
> > +#define AVCODEC_X86_VC1DSP_H
> > +
> > +#include "libavcodec/vc1dsp.h"
> > +
> > +void ff_vc1dsp_init_mmx(VC1DSPContext *dsp);
> > +void ff_vc1dsp_init_mmxext(VC1DSPContext *dsp);
> > +
> > +#endif /* AVCODEC_X86_VC1DSP_H */
> 
> Huh?  This is already declared in libavcodec/vc1dsp.h ...

AVCODEC_VC1DSP_H vs.
AVCODEC_X86_VC1DSP_H

> > --- /dev/null
> > +++ b/libavcodec/x86/vc1dsp_init.c
> > @@ -0,0 +1,124 @@
> > +
> > +#include "libavutil/cpu.h"
> > +#include "libavutil/x86/cpu.h"
> > +#include "libavcodec/vc1dsp.h"
> > +#include "vc1dsp.h"
> > +
> > +#include "config.h"
> 
> nit: drop the empty line

done locally

> Looks promising otherwise.  While you're dealing with VC-1 x86 init,
> you could have a look at the parts in dsputil_mmx.c ;)

I'll have a look but no promises

Janne
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to