Am 10.10.2012 19:57, schrieb Janne Grunau:
> Fixes bogus uninitialized value compiler and coverity warnings.
> ---
> libavcodec/ivi_common.c | 4 ++--
> libavcodec/ivi_dsp.c | 5 +++--
> libavcodec/ivi_dsp.h | 6 ++----
> 3 files changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/libavcodec/ivi_common.c b/libavcodec/ivi_common.c
> index d1a86c4..d48014c 100644
> --- a/libavcodec/ivi_common.c
> +++ b/libavcodec/ivi_common.c
> @@ -808,9 +808,9 @@ int ff_ivi_decode_frame(AVCodecContext *avctx, void
> *data, int *data_size,
>
> if (ctx->is_scalable) {
> if (avctx->codec_id == AV_CODEC_ID_INDEO4)
> - ff_ivi_recompose_haar(&ctx->planes[0], ctx->frame.data[0],
> ctx->frame.linesize[0], 4);
> + ff_ivi_recompose_haar(&ctx->planes[0], ctx->frame.data[0],
> ctx->frame.linesize[0]);
> else
> - ff_ivi_recompose53 (&ctx->planes[0], ctx->frame.data[0],
> ctx->frame.linesize[0], 4);
> + ff_ivi_recompose53 (&ctx->planes[0], ctx->frame.data[0],
> ctx->frame.linesize[0]);
> } else {
> ff_ivi_output_plane(&ctx->planes[0], ctx->frame.data[0],
> ctx->frame.linesize[0]);
> }
It would be nice to add a description why "num_bands" has been set to
that fixed value. The original routines support partial recomposition if
one or several bands are not available for whatever reason (insufficient
processor power or corrupted frame data). Therefore, the caller could
tell the wavelet transform how much bands are available using this
parameter.
Libav's implementation does currently support neither any processor
speed measurements nor any bitstream data recovery. Therefore, this last
parameter is practically useless in that implementation.
But, IMHO, it should be well documented at least...
Thanks
Best regards
Maxim P. (the author of the original indeo45 code)
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
