On Sat, 13 Oct 2012, Hendrik Leppkes wrote:
On Sat, Oct 13, 2012 at 9:43 PM, Martin Storsjö <[email protected]> wrote:The name mingw32 as target OS is both misleading, and very little of the target OS specific settings actually match.Since the target OS default is set based on uname, the default (which on MSYS is set to mingw) is overridden by --toolchain=msvc. --- configure | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 0992ff7..b30d69b 100755 --- a/configure +++ b/configure @@ -2033,8 +2033,6 @@ if enabled cross_compile; then die "Must specify target arch and OS when cross-compiling" fi -set_default arch target_os - ar_default="${cross_prefix}${ar_default}" cc_default="${cross_prefix}${cc_default}" nm_default="${cross_prefix}${nm_default}" @@ -2049,13 +2047,14 @@ case "$toolchain" in ld_default="c99wrap link" nm_default="dumpbin -symbols" ar_default="lib" + target_os_default="win32"If we want "win64" to be a thing, maybe it should differentiate here and set the appropriate one?
Currently it doesn't matter at all which one of them you set, so it's not really necessary here, but it might ease the mind of some caller who wants to set --target-os=win64.
// Martin
_______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
