Diego Biurrun <[email protected]> writes: > On Wed, Oct 17, 2012 at 08:42:41PM +0200, Luca Barbato wrote: >> On 10/17/2012 07:31 PM, Diego Biurrun wrote: >> > On Tue, Oct 16, 2012 at 06:02:40PM +0200, Luca Barbato wrote: >> >> --- /dev/null >> >> +++ b/libavfilter/compare.h >> >> @@ -0,0 +1,40 @@ >> >> + >> >> +typedef struct { >> >> +} CmpContext; >> > >> > Please no more anonymously typedeffed structs in headers, I just removed >> > them everywhere else. >> >> It is a local header... nobody beside this code will use it. > > Yes, but it sets a precedent. How do you suppose we can maintain the > situation wrt typedefs if we allow exceptions. And it's only used by > that code now, in the future that may change and we get the same > problem again ...
I also fail to see how it being used only locally is at all relevant. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
