Diego Biurrun <[email protected]> writes: > On Sat, Oct 20, 2012 at 12:54:14AM +0100, Måns Rullgård wrote: >> Diego Biurrun <[email protected]> writes: >> > --- a/tests/fate/aac.mak >> > +++ b/tests/fate/aac.mak >> > @@ -46,18 +46,10 @@ FATE_AAC += fate-aac-al_sbr_ps_06_ur >> > fate-aac-al_sbr_ps_06_ur: CMD = pcm -i $(SAMPLES)/aac/al_sbr_ps_06_new.mp4 >> > fate-aac-al_sbr_ps_06_ur: REF = $(SAMPLES)/aac/al_sbr_ps_06_ur.s16 >> > >> > -FATE_AAC += fate-aac-latm_000000001180bc60 >> > -fate-aac-latm_000000001180bc60: CMD = pcm -i >> > $(SAMPLES)/aac/latm_000000001180bc60.mpg >> > -fate-aac-latm_000000001180bc60: REF = >> > $(SAMPLES)/aac/latm_000000001180bc60.s16 >> > - >> > FATE_AAC += fate-aac-ap05_48 >> > fate-aac-ap05_48: CMD = pcm -i $(SAMPLES)/aac/ap05_48.mp4 >> > fate-aac-ap05_48: REF = $(SAMPLES)/aac/ap05_48.s16 >> > >> > -FATE_AAC += fate-aac-latm_stereo_to_51 >> > -fate-aac-latm_stereo_to_51: CMD = pcm -i >> > $(SAMPLES)/aac/latm_stereo_to_51.ts -channel_layout 5.1 >> > -fate-aac-latm_stereo_to_51: REF = $(SAMPLES)/aac/latm_stereo_to_51_ref.s16 >> > - >> > fate-aac-ct%: CMD = pcm -i >> > $(SAMPLES)/aac/CT_DecoderCheck/$(@:fate-aac-ct-%=%) >> > fate-aac-ct%: REF = $(SAMPLES)/aac/CT_DecoderCheck/aacPlusv2.wav >> > >> > @@ -71,7 +63,17 @@ FATE_AAC_CT = sbr_bc-ps_i.3gp \ >> > >> > FATE_AAC += $(FATE_AAC_CT:%=fate-aac-ct-%) >> > >> > -FATE_SAMPLES_AVCONV += $(FATE_AAC) >> > +FATE_AAC_LATM += fate-aac-latm_000000001180bc60 >> > +fate-aac-latm_000000001180bc60: CMD = pcm -i >> > $(SAMPLES)/aac/latm_000000001180bc60.mpg >> > +fate-aac-latm_000000001180bc60: REF = >> > $(SAMPLES)/aac/latm_000000001180bc60.s16 >> > + >> > +FATE_AAC_LATM += fate-aac-latm_stereo_to_51 >> > +fate-aac-latm_stereo_to_51: CMD = pcm -i >> > $(SAMPLES)/aac/latm_stereo_to_51.ts -channel_layout 5.1 >> > +fate-aac-latm_stereo_to_51: REF = $(SAMPLES)/aac/latm_stereo_to_51_ref.s16 >> > + >> > +$(FATE_AAC) $(FATE_AAC_LATM): CMP = oneoff >> > +$(FATE_AAC) $(FATE_AAC_LATM): FUZZ = 2 >> > + >> > +FATE_SAMPLES_AVCONV += $(FATE_AAC) $(FATE_AAC_LATM) >> > fate-aac: $(FATE_AAC) >> > -$(FATE_AAC): CMP = oneoff >> > -$(FATE_AAC): FUZZ = 2 >> > +fate-aac-latm: $(FATE_AAC_LATM) >> > -- >> >> Why the huge shuffle? > > See 05/10 in the series - aac_latm depends on aac_latm_decoder and > mpegts_demuxer while all the other tests depend on aac_decoder and > mov_demuxer. Thus I placed aac_latm in a separate group to be able > to give it separate dependencies.
That doesn't answer the question. There is no need to reorder them just to change a couple of names. With what you've done, the actual change is buried so deeply in the noise that nobody can find it. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
