Reinhard Tartler <[email protected]> writes: > Earlier versions of for instance libavcodec expect this symbol to be > present in libavutil. It can be removed at the next major bump. > --- > libavcodec/mathtables.c | 3 +++ > libavutil/mathematics.c | 13 +++++++++++++ > libavutil/version.h | 3 +++ > 3 files changed, 19 insertions(+) > > No need to become aggressive nor offended. On my test system, the > problem of colliding symbol is masked by our symbol scripts, so I didn't > notice them in our tests.
A plain old static build would have shown it. > This revised patch takes out the definition of ff_sqrt_tab from > avcodec without breaking the binaries. Obviously, we get a small > performance hit in the shared library case, but considering the > circumstances, I think that this is acceptable in this case. > > Note that I'm not particularily happy with the '#if 0' part, suggestions > are welcome. However, fixing the resulting linking failure on the next > avutil bump should be both easy to catch and fix. Put the table in a file of its own. It's that simple, and it has been explained a million times already. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
