Hi, On Fri, Nov 16, 2012 at 8:43 AM, Janne Grunau <[email protected]>wrote:
> I'm not entirely convinced that is the the correct/best way to fix the > problem with this sample. It crashes in draw_edges_10_c because the > image format and parameters has just 8 bit per pixels. > > The main problem I see is that it does far too many context re-inits. > > Janne > ---8<--- > > Fixes a crash in the fuzzed sample sample_varPAR.avi_s26638 with > alternating bit depths. > --- > libavcodec/h264.c | 88 > ++++++++++++++++++++++++++++++------------------------- > 1 file changed, 48 insertions(+), 40 deletions(-) > So ... I originally added code to not support changing bitdepth at all, basically to prevent this and alike issues. E.g., what if the reference is 8bit but the next frame is 10bit? What if we're using frame threading at the same time? So I wouldn't mind just erroring out altogether, unless you think this can really be made to work? I mean, if we want to support reinits, with frame threading, then we should just rewrite the init code and allow complete reinits and be convinced it always works, like we are for ffvp8. Ronald
_______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
