Sean McGovern <[email protected]> writes:

> The Solaris -rpath linker option parser is greedy.
> ---
>  configure | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/configure b/configure
> index f094a32..79e4897 100755
> --- a/configure
> +++ b/configure
> @@ -3622,6 +3622,11 @@ case $target_os in
>      plan9)
>          add_cppflags -Dmain=plan9_main
>      ;;
> +    sunos)
> +        # The Solaris linker doesn't understand -rpath-link
> +        # but does accept -rpath with the rest of the option string
> +        LDFLAGS=$(filter_out '-Wl,-rpath-link*' $LDFLAGS)
> +    ;;
>  esac

If this option doesn't work, how does the link editor find the right
libraries?  Alternatively, if it works without that option, why do we
pass it at all?  I tested it on Linux, and everything links properly
without this flag (and no libav libs elsewhere on the system).

Either way, I dislike the way this patch is done.

-- 
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to