On Thu, Nov 29, 2012 at 05:11:01PM +0200, Martin Storsjö wrote: > On Thu, 29 Nov 2012, Diego Biurrun wrote: > >On Thu, Nov 29, 2012 at 04:33:14PM +0200, Martin Storsjö wrote: > >>The existence of MapViewOfFile isn't linked to the existence of > >>io.h. > >> > >>--- a/libavutil/file.c > >>+++ b/libavutil/file.c > >>@@ -25,10 +25,12 @@ > >> #if HAVE_UNISTD_H > >> #include <unistd.h> > >> #endif > >>+#if HAVE_IO_H > >>+#include <io.h> > >>+#endif > >> #if HAVE_MMAP > >> #include <sys/mman.h> > >> #elif HAVE_MAPVIEWOFFILE > >>-#include <io.h> > >> #include <windows.h> > >> #endif > > > >What about the remaining, differently guarded io.h #include in > >libavutil/log.c? > > So far, I haven't seen any windows version that lacks io.h, so it > isn't a problem in that way. The SetConsole* stuff in that block in > log.c is problematic though, I've got other unfinished patches for > that area.
OK - push anytime. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
