On 2012-12-02 20:10:08 +0000, Måns Rullgård wrote:
> Janne Grunau <[email protected]> writes:
> 
> > -seektest(){
> > -    t="${test#seek-}"
> > -    ref=${base}/ref/seek/$t
> > -    case $t in
> > -        image_*) file="tests/data/images/${t#image_}/%02d.${t#image_}" ;;
> > -        *)       file=$(echo $t | tr _ '?')
> > -                 for d in fate/acodec- fate/vsynth2- lavf/; do
> > -                     test -f tests/data/$d$file && break
> > -                 done
> > -                 file=$(echo tests/data/$d$file)
> > -                 ;;
> > -    esac
> > -    run libavformat/seek-test $target_path/$file
> > -}
> 
> Nice to see that eyesore gone.
> 
> > diff --git a/tests/fate/acodec.mak b/tests/fate/acodec.mak
> > index 71521ab..4f73dfd 100644
> > --- a/tests/fate/acodec.mak
> > +++ b/tests/fate/acodec.mak
> > @@ -2,6 +2,7 @@ fate-acodec-%: CODEC = $(@:fate-acodec-%=%)
> >  fate-acodec-%: SRC = tests/data/asynth-44100-2.wav
> >  fate-acodec-%: CMD = enc_dec wav $(SRC) $(FMT) "-b 128k -c $(CODEC)" wav 
> > "-c pcm_s16le" -keep
> >  fate-acodec-%: CMP_UNIT = 2
> > +fate-acodec-%: REF = $(SRC_PATH)/tests/ref/fate/$(@:fate-%=%)
> >
> >  FATE_ACODEC_PCM-$(call ENCDEC, PCM_ALAW,  WAV) += alaw
> >  FATE_ACODEC_PCM-$(call ENCDEC, PCM_MULAW, WAV) += mulaw
> 
> What's this?

REF variable from seek.mak takes otherwise precedence and the acodec
tests error out with "reference file
'/home/janne/src/libav/tests/ref/seek/fate-acodec-pcm-alaw' not found"

Keeping the seek test reference files in their own directory seemed like
an good idea.

Same for vcodec.mak

> 
> [...]
> 
> > +$(FATE_SEEK): CMD = run libavformat/seek-test$(EXESUF) tests/data/$(SRC)
> 
> This needs $(TARGET_PATH)

fixed locally

Janne
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to