On Sun, Dec 02, 2012 at 11:21:35PM +0000, Måns Rullgård wrote: > Diego Biurrun <[email protected]> writes: > > On Sun, Dec 02, 2012 at 11:06:07PM +0000, Måns Rullgård wrote: > >> Diego Biurrun <[email protected]> writes: > >> > --- a/tests/fate/fft.mak > >> > +++ b/tests/fate/fft.mak > >> > @@ -38,5 +38,7 @@ $(FATE_FFT_FIXED): libavcodec/fft-fixed-test$(EXESUF) > >> > $(FATE_FFT_FIXED): CMD = run libavcodec/fft-fixed-test > >> > $(CPUFLAGS:%=-c%) $(ARGS) > >> > $(FATE_FFT_FIXED): REF = /dev/null > >> > > >> > -FATE-$(CONFIG_FFT) += $(FATE_FFT) $(FATE_FFT_FIXED) > >> > -fate-fft: $(FATE_FFT) $(FATE_FFT_FIXED) > >> > +FATE_FFT_ALL-$(call ALLYES, AVCODEC FFT) += $(FATE_FFT) > >> > $(FATE_FFT_FIXED) > >> > + > >> > +FATE += $(FATE_FFT_ALL-yes) > >> > +fate-fft: $(FATE_FFT_ALL-yes) > >> > -- > >> > >> This change is more complicated than it needs to be. > > > > How would you do it instead? > > -FATE-$(CONFIG_FFT) += $(FATE_FFT) $(FATE_FFT_FIXED) > +FATE-$(call ALLYES, AVCODEC FFT) += $(FATE_FFT) $(FATE_FFT_FIXED)
That's obvious, but it does not change the "fate-fft" target, which would fail if the dependencies are not met. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
