On 12/06/2012 07:25 PM, Janne Grunau wrote:
> Avoids reads of uninitialized memory in ff_lpc_calc_coefs() during
> fate-flac-16-lpc-cholesky.
> ---
> libavcodec/flacenc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/flacenc.c b/libavcodec/flacenc.c
> index 54bc64c..7808e20 100644
> --- a/libavcodec/flacenc.c
> +++ b/libavcodec/flacenc.c
> @@ -1299,7 +1299,7 @@ static const AVOption options[] = {
> { "fixed", NULL, 0, AV_OPT_TYPE_CONST, {.i64 = FF_LPC_TYPE_FIXED },
> INT_MIN, INT_MAX, FLAGS, "lpc_type" },
> { "levinson", NULL, 0, AV_OPT_TYPE_CONST, {.i64 = FF_LPC_TYPE_LEVINSON },
> INT_MIN, INT_MAX, FLAGS, "lpc_type" },
> { "cholesky", NULL, 0, AV_OPT_TYPE_CONST, {.i64 = FF_LPC_TYPE_CHOLESKY },
> INT_MIN, INT_MAX, FLAGS, "lpc_type" },
> -{ "lpc_passes", "Number of passes to use for Cholesky factorization during
> LPC analysis", offsetof(FlacEncodeContext, options.lpc_passes),
> AV_OPT_TYPE_INT, {.i64 = -1 }, INT_MIN, INT_MAX, FLAGS },
> +{ "lpc_passes", "Number of passes to use for Cholesky factorization during
> LPC analysis", offsetof(FlacEncodeContext, options.lpc_passes),
> AV_OPT_TYPE_INT, {.i64 = 1 }, 1, INT_MAX, FLAGS },
> { "min_partition_order", NULL, offsetof(FlacEncodeContext,
> options.min_partition_order), AV_OPT_TYPE_INT, {.i64 = -1 }, -1,
> MAX_PARTITION_ORDER, FLAGS },
> { "max_partition_order", NULL, offsetof(FlacEncodeContext,
> options.max_partition_order), AV_OPT_TYPE_INT, {.i64 = -1 }, -1,
> MAX_PARTITION_ORDER, FLAGS },
> { "prediction_order_method", "Search method for selecting prediction order",
> offsetof(FlacEncodeContext, options.prediction_order_method),
> AV_OPT_TYPE_INT, {.i64 = -1 }, -1, ORDER_METHOD_LOG, FLAGS, "predm" },
LGTM. The -1 default is not needed since the last major bump.
-Justin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
