On 12/01/2012 06:18 AM, Christophe Gisquet wrote:
> Corrected 2 vs 4-spaces tabs and base4 constants.
> 
> 
> 0005-SBR-DSP-x86-implement-SSE-qmf_deint_neg.patch
> 
> 
> From 50f9cc2718ac7a290f46f3e34a8cf747d107330b Mon Sep 17 00:00:00 2001
> From: Christophe Gisquet <[email protected]>
> Date: Mon, 26 Nov 2012 22:26:20 +0100
> Subject: [PATCH 05/11] SBR DSP x86: implement SSE qmf_deint_neg
> 
> No vector tests it.
> ---
>  libavcodec/x86/sbrdsp.asm    |   19 +++++++++++++++++++
>  libavcodec/x86/sbrdsp_init.c |    2 ++
>  2 files changed, 21 insertions(+), 0 deletions(-)
> 
> diff --git a/libavcodec/x86/sbrdsp.asm b/libavcodec/x86/sbrdsp.asm
> index d5c93e3..cf9d904 100644
> --- a/libavcodec/x86/sbrdsp.asm
> +++ b/libavcodec/x86/sbrdsp.asm
> @@ -247,3 +247,22 @@ cglobal sbr_qmf_pre_shuffle, 1,4,4,z
>      jl      .loop
>      movh  [r3q-256], m3
>      REP_RET
> +
> +cglobal sbr_qmf_deint_neg, 2,3,4,v,src,vrev

needs INIT_XMM sse

> +    lea     vrevq, [vq + (64-4)*4]
> +    add      srcq, (64-8)*4
> +    mova       m3, [ps_neg]
> +.loop:
> +    mova       m0, [srcq +  0]
> +    mova       m1, [srcq + 16]
> +    mova       m2, m1
> +    shufps     m0, m1, q3131
> +    shufps     m2, m1, q2020

I don't quite get the use of m2 here. It looks unnecessary.

> +    xorps      m0, m3
> +    mova     [vq], m2
> +    mova  [vrevq], m0
> +    add        vq, 16
> +    sub     vrevq, 16
> +    sub      srcq, 32
> +    cmp        vq, vrevq
> +    jl      .loop

Where is the return?

-Justin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to