Josh Allmann <[email protected]> writes: > On 7 December 2012 14:23, Martin Storsjö <[email protected]> wrote: >> On Fri, 7 Dec 2012, Mans Rullgard wrote: >> >>> When LOCAL_ALIGNED uses manual alignment initialisation is not >>> possible. >>> > > There's another case further down. > > diff --git a/libavcodec/takdec.c b/libavcodec/takdec.c > index 0ac870c..d47db48 100644 > --- a/libavcodec/takdec.c > +++ b/libavcodec/takdec.c > @@ -601,10 +601,12 @@ static int decorrelate(TAKDecContext *s, int c1, > int c2, int length) > case 6: > FFSWAP(int32_t*, p1, p2); > case 7: { > - LOCAL_ALIGNED_16(int16_t, filter, [MAX_PREDICTORS]) = { 0 }; > + LOCAL_ALIGNED_16(int16_t, filter, [MAX_PREDICTORS]); > int length2, order_half, filter_order, dval1, dval2; > int av_uninit(code_size); > > + memset(filter, 0, MAX_PREDICTORS * sizeof(*filter)); > + > if (length < 256) > return AVERROR_INVALIDDATA;
FUUUUUCK How goddamn hard can it be for people to spot these in reviews??!@!! I don't have time to scan each and every line of each and every patch posted in search of these errors. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
