Diego Biurrun <[email protected]> writes:
> ---
> libavcodec/arm/fmtconvert_vfp.S | 2 +-
> libavcodec/options_table.h | 98 +++++++++++++++++++-------------------
> libavcodec/sh4/dsputil_align.c | 2 +-
> libavformat/avio_internal.h | 2 +-
> libavformat/bethsoftvid.c | 2 +-
> libavformat/nsvdec.c | 2 +-
> libavutil/log.h | 17 ++++---
> libavutil/pixfmt.h | 54 +++++++++++-----------
> 8 files changed, 90 insertions(+), 89 deletions(-)
There's a lot more than mere typo fixes in this patch.
> - * performance), little endian byte sex
> + * performance), little-endian byte sex.
Replacing "foo endian" with "foo-endian" is OK.
> -{"mv4", "use four motion vector by macroblock (mpeg4)", 0,
> AV_OPT_TYPE_CONST, {.i64 = CODEC_FLAG_4MV }, INT_MIN, INT_MAX, V|E, "flags"},
> +{"mv4", "use four motion vectors per macroblock (MPEG-4)", 0,
> AV_OPT_TYPE_CONST, {.i64 = CODEC_FLAG_4MV }, INT_MIN, INT_MAX, V|E, "flags"},
> -{"emu_edge", "don't draw edges", 0, AV_OPT_TYPE_CONST, {.i64 =
> CODEC_FLAG_EMU_EDGE }, INT_MIN, INT_MAX, 0, "flags"},
> +{"emu_edge", "do not draw edges", 0, AV_OPT_TYPE_CONST, {.i64 =
> CODEC_FLAG_EMU_EDGE }, INT_MIN, INT_MAX, 0, "flags"},
> -{"ildct", "use interlaced dct", 0, AV_OPT_TYPE_CONST, {.i64 =
> CODEC_FLAG_INTERLACED_DCT }, INT_MIN, INT_MAX, V|E, "flags"},
> +{"ildct", "use interlaced DCT", 0, AV_OPT_TYPE_CONST, {.i64 =
> CODEC_FLAG_INTERLACED_DCT }, INT_MIN, INT_MAX, V|E, "flags"},
> -{"bitexact", "use only bitexact stuff (except (i)dct)", 0,
> AV_OPT_TYPE_CONST, {.i64 = CODEC_FLAG_BITEXACT }, INT_MIN, INT_MAX,
> A|V|S|D|E, "flags"},
> -{"aic", "h263 advanced intra coding / mpeg4 ac prediction", 0,
> AV_OPT_TYPE_CONST, {.i64 = CODEC_FLAG_AC_PRED }, INT_MIN, INT_MAX, V|E,
> "flags"},
> +{"bitexact", "use only bitexact code (except (I)DCT)", 0, AV_OPT_TYPE_CONST,
> {.i64 = CODEC_FLAG_BITEXACT }, INT_MIN, INT_MAX, A|V|S|D|E, "flags"},
> +{"aic", "H.263 advanced intra coding / MPEG-4 ac prediction", 0,
> AV_OPT_TYPE_CONST, {.i64 = CODEC_FLAG_AC_PRED }, INT_MIN, INT_MAX, V|E,
> "flags"},
> -{"cgop", "closed gop", 0, AV_OPT_TYPE_CONST, {.i64 = CODEC_FLAG_CLOSED_GOP
> }, INT_MIN, INT_MAX, V|E, "flags"},
> +{"cgop", "closed GOP", 0, AV_OPT_TYPE_CONST, {.i64 = CODEC_FLAG_CLOSED_GOP
> }, INT_MIN, INT_MAX, V|E, "flags"},
These, and plenty others, are style fixes, not typo corrections.
> -{"g", "set the group of picture size", OFFSET(gop_size), AV_OPT_TYPE_INT,
> {.i64 = 12 }, INT_MIN, INT_MAX, V|E},
> +{"g", "set the group of picture (GOP) size", OFFSET(gop_size),
> AV_OPT_TYPE_INT, {.i64 = 12 }, INT_MIN, INT_MAX, V|E},
This is _adding_ text. Hardly a typo fix.
> -{"qmin", "min video quantizer scale (VBR)", OFFSET(qmin), AV_OPT_TYPE_INT,
> {.i64 = 2 }, -1, 69, V|E},
> -{"qmax", "max video quantizer scale (VBR)", OFFSET(qmax), AV_OPT_TYPE_INT,
> {.i64 = 31 }, -1, 69, V|E},
> -{"qdiff", "max difference between the quantizer scale (VBR)",
> OFFSET(max_qdiff), AV_OPT_TYPE_INT, {.i64 = 3 }, INT_MIN, INT_MAX, V|E},
> +{"qmin", "minimum video quantizer scale (VBR)", OFFSET(qmin),
> AV_OPT_TYPE_INT, {.i64 = 2 }, -1, 69, V|E},
> +{"qmax", "maximum video quantizer scale (VBR)", OFFSET(qmax),
> AV_OPT_TYPE_INT, {.i64 = 31 }, -1, 69, V|E},
> +{"qdiff", "maximum difference between the quantizer scales (VBR)",
> OFFSET(max_qdiff), AV_OPT_TYPE_INT, {.i64 = 3 }, INT_MIN, INT_MAX, V|E},
More style changes, replacing min/max with their -imum-suffixed longer
versions. I'm not sure we want to do this. Help texts should strive to
be terse, and everybody should understand the abbreviated forms.
> -{"cmp", "full pel me compare function", OFFSET(me_cmp), AV_OPT_TYPE_INT,
> {.i64 = DEFAULT }, INT_MIN, INT_MAX, V|E, "cmp_func"},
> -{"subcmp", "sub pel me compare function", OFFSET(me_sub_cmp),
> AV_OPT_TYPE_INT, {.i64 = DEFAULT }, INT_MIN, INT_MAX, V|E, "cmp_func"},
> +{"cmp", "full pel ME compare function", OFFSET(me_cmp), AV_OPT_TYPE_INT,
> {.i64 = DEFAULT }, INT_MIN, INT_MAX, V|E, "cmp_func"},
> +{"subcmp", "sub pel ME compare function", OFFSET(me_sub_cmp),
> AV_OPT_TYPE_INT, {.i64 = DEFAULT }, INT_MIN, INT_MAX, V|E, "cmp_func"},
If you're fixing these lines, you should also fix "full pel" -> "full-pel" etc.
> -{"timecode_frame_start", "GOP timecode frame start number, in non drop frame
> format", OFFSET(timecode_frame_start), AV_OPT_TYPE_INT64, {.i64 = 0 }, 0,
> INT64_MAX, V|E},
> +{"timecode_frame_start", "GOP timecode frame start number, in non-drop frame
> format", OFFSET(timecode_frame_start), AV_OPT_TYPE_INT64, {.i64 = 0 }, 0,
> INT64_MAX, V|E},
non-drop-frame
> diff --git a/libavutil/log.h b/libavutil/log.h
> index 0678e1a..ce578d3 100644
> --- a/libavutil/log.h
> +++ b/libavutil/log.h
> @@ -65,10 +65,11 @@ typedef struct AVClass {
> int log_level_offset_offset;
>
> /**
> - * Offset in the structure where a pointer to the parent context for
> loging is stored.
> - * for example a decoder that uses eval.c could pass its AVCodecContext
> to eval as such
> - * parent context. And a av_log() implementation could then display the
> parent context
> - * can be NULL of course
> + * Offset in the structure where a pointer to the parent context for
> + * loging is stored. For example a decoder that uses eval.c could pass
> + * its AVCodecContext to eval as such a parent context. And an av_log()
> + * implementation could then display the parent context.
> + * Can be NULL of course.
> */
This is merely flowing the text differently, not fixing the numerous
spelling errors within it.
--
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
