On Sun, 16 Dec 2012, Luca Barbato wrote:

On 12/12/12 4:05 PM, Martin Storsjö wrote:
+                  const uint8_t *buf, int len, uint16_t s, int flags)

Ok, not sure if this s should be expanded to seq as well.

There's a separate (unrelated) variable named 'seq' within the function as well. It is only called from within ff_rdt_parse_packet anyway, where I just call it with seq==0. Perhaps I could name this one 'rtp_seq' or something instead.

I'll hold-off this one still until 5/5 which uses it gets reviewed, that one kinda requires someone who is familiar with the VP8 internals.

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to