On Sat, Jan 05, 2013 at 05:55:59PM -0500, Daniel Kang wrote: > On Sat, Jan 5, 2013 at 5:47 PM, Diego Biurrun <[email protected]> wrote: > > On Sat, Jan 05, 2013 at 12:48:58PM -0500, Daniel Kang wrote: > >> On Sat, Jan 5, 2013 at 12:29 PM, Diego Biurrun <[email protected]> wrote: > >> > On Sat, Jan 05, 2013 at 11:01:19AM -0600, Daniel Kang wrote: > >> >> > >> >> --- a/libavfilter/x86/yadif.c > >> >> +++ b/libavfilter/x86/yadif.c > >> >> +%macro LOAD 2 > >> >> + movh m%1, %2 > >> >> + punpcklbw m%1, m7 > >> >> +%endmacro > >> >> + > >> >> +%macro ABSY 1-2 > >> >> +%if cpuflag(ssse3) > >> >> + pabsw %1, %1 > >> >> +%else > >> >> + ABS1_MMXEXT %1, %2 > >> >> +%endif > >> >> +%endmacro > >> > > >> > Is this a candidate for simply extending ABS1_MMXEXT? > >> > >> No. The MMXEXT is there for a reason. > > > > I was being totally unclear, as I was referring to some changes I only > > have locally. Please review the following patch: > > > > http://patches.libav.org/patch/25264/ > > That looks right.
Pushed, rebase your patch on top of master. There are a bunch more similar and simple patches at https://patches.libav.org/project/libav-devel/list/?submitter=22 I'd be glad to receive a few more reviews... > >> >> +%if mmsize == 16 > >> >> + mova m3, m2 > >> >> + psrldq m3, 2 > >> >> +%else > >> >> + pshufw m3, m2, 9 > >> >> +%endif > >> > > >> > Didn't we have a macro for this? > >> > >> If we do, I can't find it. > > > > h264_intrapred.asm has some very similar code that likely should be > > extracted into a common macro. > > In another patch? This patch is supposed to be a port. Yes. This is a related refactoring opportunity that should be done in another patch. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
