On 01/07/2013 04:11 PM, Diego Biurrun wrote:
> On Mon, Jan 07, 2013 at 01:23:37PM +0100, Anton Khirnov wrote:
>> --- a/libavcodec/rawdec.c
>> +++ b/libavcodec/rawdec.c
>> @@ -78,19 +79,23 @@ static av_cold int raw_init_decoder(AVCodecContext
>> *avctx)
>> - if((avctx->bits_per_coded_sample == 4 || avctx->bits_per_coded_sample
>> == 2) &&
>> - avctx->pix_fmt==AV_PIX_FMT_PAL8 &&
>> - (!avctx->codec_tag || avctx->codec_tag == MKTAG('r','a','w',' '))){
>> + if ((avctx->bits_per_coded_sample == 4 || avctx->bits_per_coded_sample
>> == 2) &&
>> + avctx->pix_fmt == AV_PIX_FMT_PAL8 &&
>> + (!avctx->codec_tag || avctx->codec_tag == MKTAG('r','a','w',' '))) {
>
> missing space after ,
>
>> @@ -98,28 +103,30 @@ static av_cold int raw_init_decoder(AVCodecContext
>> *avctx)
>>
>> - if((avctx->extradata_size >= 9 && !memcmp(avctx->extradata +
>> avctx->extradata_size - 9, "BottomUp", 9)) ||
>> - avctx->codec_tag == MKTAG(3, 0, 0, 0) || avctx->codec_tag ==
>> MKTAG('W','R','A','W'))
>> + if ((avctx->extradata_size >= 9 &&
>> + !memcmp(avctx->extradata + avctx->extradata_size - 9, "BottomUp",
>> 9)) ||
>> + avctx->codec_tag == MKTAG(3, 0, 0, 0) ||
>> + avctx->codec_tag == MKTAG('W','R','A','W'))
>
> same
I personally think leaving out the extra spaces on MKTAG and the like
makes it easier to read.
-Justin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
